RFR: 8257467: [TESTBUG] -Wdeprecated-declarations is reported at sigset() in exesigtest.c [v2]

[David Holmes]

On Tue, 1 Dec 2020 06:00:13 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

>> `sigset()` is deprecated, and `__attribute_deprecated_msg__` has been [set to the declaration in glibc](https://sourceware.org/git/?p=glibc.git;a=commit;f=signal/signal.h;h=02802fafcf6e11ea3f998f685035ffe568dfddeb)
>> 
>> We can see the warning on `make test-image` as below:
>> 
>> * Fedora 33 x86_64
>>     * gcc: gcc-10.2.1-6.fc33.x86_64
>>     * glibc: glibc-2.32-2.fc33.x86_64
>> 
>> 
>> 
>>   245 | sigset(signal_num, handler);
>>       | ^~~~~~
>> In file included from /home/ysuenaga/github-forked/jdk/test/hotspot/jtreg/runtime/signal/exesigtest.c:25:
>> 
>>   353 | extern __sighandler_t sigset (int __sig, __sighandler_t __disp) __THROW
>>       | ^~~~~~
>> cc1: all warnings being treated as errors
>> gmake[3]: *** [test/JtregNativeHotspot.gmk:1525: /home/ysuenaga/github-forked/jdk/build/linux-x86_64-server-fastdebug/support/test/hotspot/jtreg/native/support/exesigtest/exesigtest.o] Error 1
>> gmake[3]: *** Waiting for unfinished jobs....
>> gmake[2]: *** [make/Main.gmk:612: build-test-hotspot-jtreg-native] Error 2
>
> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove sigset() from signal handler tests

Just eradicate "mode" completely.

Thanks,
David

test/hotspot/jtreg/runtime/signal/README line 40:

> 38: 
> 39: Signal handlers don't do anything, so the only fact that signal handler was called is checked.
> 40: Also 2 different ways of setting signal handlers are tested: sigaction.

There is only one way now so delete this sentence.

test/hotspot/jtreg/runtime/signal/SigTestDriver.java line 96:

> 94:         boolean passed = true;
> 95: 
> 96:         for (String mode : new String[] {"sigaction"}) {

You don't need the loop any more. You don't need to pass a "mode" any more.

test/hotspot/jtreg/runtime/signal/exesigtest.c line 147:

> 145: boolean isSupportedSigMode ()
> 146: {
> 147:     if ( !strcmp(mode, "sigaction") )

You can delete the whole "mode" logic.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1529