RFR: 8244847: Linux/PPC: runtime/CompressedOops/CompressedClassPointers: smallHeapTest fails [v2]

[Richard Reingruber]

On Tue, 1 Dec 2020 14:03:05 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Richard Reingruber has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Special case for AIX in largeHeapTest().
>
> test/hotspot/jtreg/runtime/CompressedOops/CompressedClassPointers.java line 103:
> 
>> 101:         if (testNarrowKlassBase() && !Platform.isAix()) {
>> 102:             // AIX: the heap cannot be placed below 32g. The first attempt to
>> 103:             // place the CCS after the heap fails (luckily). Finally CCS is
> 
> small nits:
> s/after/behind
> s/Finally/Eventually or Subsequently

Done.

> test/hotspot/jtreg/runtime/CompressedOops/CompressedClassPointers.java line 106:
> 
>> 104:             // successfully placed below 32g. So we get 0x0 as narrow klass
>> 105:             // base.  As an enhancement the first attempt mapping the CCS should
>> 106:             // be made below 32g if oops are compressed but the heap is above 32g.
> 
> I'd remove the enhancement remark since it is slightly confusing and irrelevant to the test in its current form. If you want to mention it, could you please create a JBS issue and mention it here ("see also JDK-xxxx").

I removed it. I'll create the JBS item after some initial tests.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1512