RFR: 8256256: UL should not use heap allocation for output string [v5]
Yumin Qi
minqi at openjdk.java.net
Wed Dec 2 04:09:07 UTC 2020
> Hi, Please review
> Unified Logging uses 512 bytes buffer on stack for printing out message, above that will allocate heap for extra space needed. This may potentially may cause a circulation when we log the heap allocation and the log message is over 512. The max logging buffer size now is increased to 4096 and above that, output will be truncated.
>
> Tests: tier1,tier4
Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
Fix according to review comments, use malloc replace calloc, also check return value from (v)snprintf
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1246/files
- new: https://git.openjdk.java.net/jdk/pull/1246/files/9a2f7b79..4d1cba14
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1246&range=04
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1246&range=03-04
Stats: 30 lines in 1 file changed: 17 ins; 3 del; 10 mod
Patch: https://git.openjdk.java.net/jdk/pull/1246.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/1246/head:pull/1246
PR: https://git.openjdk.java.net/jdk/pull/1246
More information about the hotspot-runtime-dev
mailing list