RFR: 8256256: UL should not use heap allocation for output string [v5]

David Holmes dholmes at openjdk.java.net
Wed Dec 2 04:17:00 UTC 2020


On Wed, 2 Dec 2020 04:09:07 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> Hi, Please review
>>   Unified Logging uses 512 bytes buffer on stack for printing out message, above that will allocate heap for extra space needed. This may potentially may cause a circulation when we log the heap allocation and the log message is over 512. The max logging buffer size now is increased to 4096 and above that, output will be truncated.
>> 
>> Tests: tier1,tier4
>
> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix according to review comments, use malloc replace calloc, also check return value from (v)snprintf

This seems okay to me now.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1246


More information about the hotspot-runtime-dev mailing list