Integrated: 8256008: UL does not report anything if disk writing fails
Yasumasa Suenaga
ysuenaga at openjdk.java.net
Wed Dec 2 09:22:55 UTC 2020
On Sat, 7 Nov 2020 07:19:09 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:
> If there are no disk space enough to write UL, it does not report. So the user cannot know lack of logs timely.
>
> `LogFileStreamOutput::write()` uses `jio_fprintf()` and `fflush()` to write log. However return values from them would not be checked.
> We should check them, and should report what happened if error occurred.
>
>
> How to reproduce on Linux:
>
> 1. Mount tmpfs with 512K
>
> $ mkdir /tmp/tmp
> $ mount -t tmpfs -o size=512k tmpfs /tmp/tmp
>
> 2. Run `java` with `-Xlog`
>
> $ java -Xlog:all=trace:file=/tmp/tmp/all.log --version
This pull request has now been integrated.
Changeset: 3e3745c2
Author: Yasumasa Suenaga <ysuenaga at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/3e3745c2
Stats: 56 lines in 3 files changed: 37 ins; 2 del; 17 mod
8256008: UL does not report anything if disk writing fails
Reviewed-by: stuefe
-------------
PR: https://git.openjdk.java.net/jdk/pull/1106
More information about the hotspot-runtime-dev
mailing list