RFR: 8256474: Migrate Mutex _owner accesses to use Atomic operations [v3]

Daniel D.Daugherty dcubed at openjdk.java.net
Wed Dec 2 15:13:58 UTC 2020


On Tue, 24 Nov 2020 22:39:08 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Simple update to move away from volatile fields and use Atomic::load/store on racy accesses.
>> 
>> Thanks,
>> David
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Restore volatile modifier

Sorry for the late review. Looks good to me.

The only thing that I noticed was you went with a "raw_" prefix with your
raw_set_owner() and I went with a "_raw" suffix with my ObjectMonitor::owner_raw().
Nothing wrong with either, but the difference stood out.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1402


More information about the hotspot-runtime-dev mailing list