RFR: JDK-8257588: Make os::_page_sizes a set [v2]
Thomas Stuefe
stuefe at openjdk.java.net
Thu Dec 3 13:17:59 UTC 2020
On Thu, 3 Dec 2020 09:50:54 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix 32bit issues
>
> src/hotspot/share/runtime/os.hpp line 103:
>
>> 101:
>> 102: public:
>> 103:
>
> The class PagesizeSet does not need to be public.
Would it be okay to leave this public anyway? It is used from the gtests. I could make a fixture class and make it friend of os but that would be similarly ugly.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1522
More information about the hotspot-runtime-dev
mailing list