RFR: 8252797: Non-PCH build fails on Ubuntu 16.4 when building with gtests

David Holmes dholmes at openjdk.java.net
Mon Dec 7 23:31:11 UTC 2020


On Mon, 7 Dec 2020 21:15:32 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

> This is a workaround for GCC 5.4 bug that is triggered by a particular pattern of math header usage as is the case here with our gtest suite.
> 
> Thank you to Mikael Vidstedt for finding the GCC bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=14608 , triggered by gtest usage as described here https://github.com/google/googletest/commit/fe4d5f10840c5f62b984364a4d41719f1bc079a2
> 
> Thank you to Ioi for debugging the issue and coming up with the workaround used in this fix.

Looks good and trivial.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1678


More information about the hotspot-runtime-dev mailing list