RFR: 8251267: CDS tests should use CDSTestUtils.getOutputDir instead of System.getProperty("user.dir")

Calvin Cheung ccheung at openjdk.java.net
Tue Dec 8 20:03:36 UTC 2020


On Tue, 8 Dec 2020 18:43:08 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> Replacing
>>     `String s = System.getProperty("user.dir");` 
>> with
>>     `String s = CDSTestUtils.getOutputDir(); `
>> 
>> Replacing
>>     `File dir = new File(System.getProperty("user.dir"));`
>> with
>>     `File dir = CDSTestUtils.getOutputDirAsFile();`
>> 
>> Passed tier1, hs-tiers 2/3/4 tests.
>
> Looks good!

@yminqi, @iklam, thanks for the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1700


More information about the hotspot-runtime-dev mailing list