RFR: 8257872: UL: -Xlog does not check number of options [v2]

Koichi Sakata ksakata at openjdk.java.net
Wed Dec 9 00:09:39 UTC 2020


On Tue, 8 Dec 2020 06:13:18 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Koichi Sakata has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change the warning message
>
> src/hotspot/share/logging/logConfiguration.cpp line 371:
> 
>> 369: 
>> 370:   if (str != NULL) {
>> 371:     log_warning(logging)("Options are specified more than the max number in -Xlog.");
> 
> Might I suggest:
> `log_warning(logging)("Ignoring excess -Xlog options: "%s"", str);`

Thank you for your suggestion. This message is clear for everyone. I changed the warning message.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1685


More information about the hotspot-runtime-dev mailing list