RFR: 8251438: Issues with our POSIX set_signal_handler()

[Gerard Ziemski]

On Thu, 10 Dec 2020 20:03:47 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Hi Gerard,
>> Functionally this is fine. Stylistically I would have just done simply:
>> 
>> return (act.sa_flags & SA_SIGINFO) != 0 ? CAST_FROM_FN_PTR(address, act.sa_sigaction) : CAST_FROM_FN_PTR(address, act.sa_handler);
>> 
>> Thanks,
>> David
>
>> Hi Gerard,
>> Functionally this is fine. Stylistically I would have just done simply:
>> 
>> return (act.sa_flags & SA_SIGINFO) != 0 ? CAST_FROM_FN_PTR(address, act.sa_sigaction) : CAST_FROM_FN_PTR(address, act.sa_handler);
>> 
>> Thanks,
>> David
> 
> Thank you David for the review, but I need to pull it out of JDK16 and redo for JDK17. I think I need to withdraw and close it.

I was told that all I need to do is to wait till official JDK16->JDK17 switch over, and can use this PR for JDK17.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1680