RFR: 8251438: Issues with our POSIX set_signal_handler() [v2]

[Gerard Ziemski]

On Sat, 12 Dec 2020 07:32:30 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Thank you Thomas for the review.
>> 
>> How about:
>> 
>> `static address get_signal_handler(struct sigaction &action)`
>> 
>> ?
>
> Meh. I am not a big fan of references :) since at the call site they are indistinguishable from by-value parameters. But if you use them, please make them const.

I checked the existing code and decided to use the `get_signal_handler(const struct sigaction* action)` type after all, as that's what all other functions, except for one, use.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1680