RFR: 8258438: build error in test/hotspot/gtest/runtime/test_os.cpp
Ioi Lam
iklam at openjdk.java.net
Tue Dec 15 21:37:05 UTC 2020
Please review this trivial fix for mach5 tier1 build failure:
test/hotspot/gtest/runtime/test_os.cpp:525:39: error: cannot convert 'const MEMFLAGS' to 'bool'
char* p = os::reserve_memory(1 * M, mtInternal);
^^^^^^^^^^
It's caused by the following change in [os.hpp](url) in [JDK-8234930](https://bugs.openjdk.java.net/browse/JDK-8234930):
- static char* reserve_memory(size_t bytes, MEMFLAGS flags = mtOther);
+ static char* reserve_memory(size_t bytes, bool executable = false, MEMFLAGS flags = mtOther);
I am running a personal tier1 job to validate this fix.
-------------
Commit messages:
- 8258438: build error in test/hotspot/gtest/runtime/test_os.cpp
Changes: https://git.openjdk.java.net/jdk/pull/1788/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1788&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8258438
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.java.net/jdk/pull/1788.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/1788/head:pull/1788
PR: https://git.openjdk.java.net/jdk/pull/1788
More information about the hotspot-runtime-dev
mailing list