RFR: 8258438: build error in test/hotspot/gtest/runtime/test_os.cpp

[Thomas Schatzl]

On Tue, 15 Dec 2020 21:26:48 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Please review this trivial fix for mach5 tier1 build failure:
> 
> test/hotspot/gtest/runtime/test_os.cpp:525:39: error: cannot convert 'const MEMFLAGS' to 'bool'
>      char* p = os::reserve_memory(1 * M, mtInternal);
>                                          ^^^^^^^^^^
> 
> It's caused by the following change in [os.hpp](url) in [JDK-8234930](https://bugs.openjdk.java.net/browse/JDK-8234930):
> 
> - static char*  reserve_memory(size_t bytes, MEMFLAGS flags = mtOther);
> + static char*  reserve_memory(size_t bytes, bool executable = false, MEMFLAGS flags = mtOther);
> 
> I am running a personal tier1 job to validate this fix.

Marked as reviewed by tschatzl (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1788