RFR: 8256213: Remove os::split_reserved_memory
Calvin Cheung
ccheung at openjdk.java.net
Fri Dec 18 17:32:54 UTC 2020
On Thu, 17 Dec 2020 19:05:00 GMT, Yumin Qi <minqi at openjdk.org> wrote:
> Hi, Please review
> This is the second step for removing problematic os::split_reserved_memory on Windows. The first step has been accomplished under bug 8255917 (https://bugs.openjdk.java.net/browse/JDK-8255917).
> This step remove the function split_reserved_memory which no longer be called after first step.
>
> Tests: tier1-4
>
> Thanks
> Yumin
Looks good other than a minor cleanup.
src/hotspot/share/memory/virtualspace.hpp line 83:
> 81:
> 82: // These simply call the above using the default alignment.
> 83: inline ReservedSpace first_part(size_t partition_size/*, bool split = false*/);
Forgot to remove the comment code `/*, bool split = false*/`?
-------------
Marked as reviewed by ccheung (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1825
More information about the hotspot-runtime-dev
mailing list