RFR: JDK-8258606: os::print_signal_handlers() should resolve the function name of the handlers [v3]

[Thomas Stuefe]

On Tue, 22 Dec 2020 13:17:12 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - style changes
>>  - Fix Windows gtests
>
> src/hotspot/share/runtime/os.cpp line 906:
> 
>> 904:   }
>> 905:   int offset = 0;
>> 906:   const bool have_function_name = dll_address_to_function_name(addr, p, buflen,
> 
> So this function includes the arguments in the string that it returns?  The arguments make the output long and don't add anything helpful in my opinion, but it's not really worth having the code to strip them out.

Hi Coleen, thanks for the review!

You are right. I modified the patch and removed the arguments, which did not make the code much more complex but reads better. Now it looks like this:

657 Signal Handlers:
658    SIGSEGV: crash_handler+0 in libjvm.so, sa_mask[0]=11100100010111111101111111111110, sa_flags=SA_RESTART|SA_SIGINFO
659     SIGBUS: crash_handler+0 in libjvm.so, sa_mask[0]=11100100010111111101111111111110, sa_flags=SA_RESTART|SA_SIGINFO
660     SIGFPE: crash_handler+0 in libjvm.so, sa_mask[0]=11100100010111111101111111111110, sa_flags=SA_RESTART|SA_SIGINFO
661    SIGPIPE: javaSignalHandler+0 in libjvm.so, sa_mask[0]=11100100010111111101111111111110, sa_flags=SA_RESTART|SA_SIGINFO
662    SIGXFSZ: javaSignalHandler+0 in libjvm.so, sa_mask[0]=11100100010111111101111111111110, sa_flags=SA_RESTART|SA_SIGINFO
663     SIGILL: crash_handler+0 in libjvm.so, sa_mask[0]=11100100010111111101111111111110, sa_flags=SA_RESTART|SA_SIGINFO
664    SIGUSR2: SR_handler+0 in libjvm.so, sa_mask[0]=00000000000000000000000000000000, sa_flags=SA_RESTART|SA_SIGINFO
665     SIGHUP: UserHandler+0 in libjvm.so, sa_mask[0]=11100100010111111101111111111110, sa_flags=SA_RESTART|SA_SIGINFO
666     SIGINT: UserHandler+0 in libjvm.so, sa_mask[0]=11100100010111111101111111111110, sa_flags=SA_RESTART|SA_SIGINFO
667    SIGTERM: UserHandler+0 in libjvm.so, sa_mask[0]=11100100010111111101111111111110, sa_flags=SA_RESTART|SA_SIGINFO
668    SIGQUIT: UserHandler+0 in libjvm.so, sa_mask[0]=11100100010111111101111111111110, sa_flags=SA_RESTART|SA_SIGINFO
669    SIGTRAP: crash_handler+0 in libjvm.so, sa_mask[0]=11100100010111111101111111111110, sa_flags=SA_RESTART|SA_SIGINFO

-------------

PR: https://git.openjdk.java.net/jdk/pull/1839