RFR(XS) 8239854: Cannot build gtest without PCH after 8239235. Missing include in test/hotspot/gtest/runtime/test_signatureStream.cpp

[Doerr, Martin]

Hi Richard,

thanks for fixing this issue.

Can you sort the includes alphabetically, please?

Why did you change the brace at the end?

Best regards,
Martin


> -----Original Message-----
> From: hotspot-runtime-dev <hotspot-runtime-dev-
> bounces at openjdk.java.net> On Behalf Of Reingruber, Richard
> Sent: Montag, 24. Februar 2020 11:35
> To: Claes Redestad <claes.redestad at oracle.com>; hotspot-runtime-
> dev at openjdk.java.net
> Subject: [CAUTION] RFR(XS) 8239854: Cannot build gtest without PCH after
> 8239235. Missing include in
> test/hotspot/gtest/runtime/test_signatureStream.cpp
> 
> Hi,
> 
> I get the following error (after JDK-8239235) when building without
> precompiled headers:
> 
> /priv/d038402/hg/jdk/test/hotspot/gtest/runtime/test_signatureStream.cp
> p: In member function 'virtual void
> SignatureStream_check_refcount_test_vm_Test::TestBody()':
> /priv/d038402/hg/jdk/test/hotspot/gtest/runtime/test_signatureStream.cp
> p:37:25: error: variable 'ResourceMark rm' has initializer but incomplete type
>    ResourceMark rm(THREAD);
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8239854
> 
> I would like to fix this with the patch below.
> 
> Thanks,
> Richard.
> 
> diff --git a/test/hotspot/gtest/runtime/test_signatureStream.cpp
> b/test/hotspot/gtest/runtime/test_signatureStream.cpp
> --- a/test/hotspot/gtest/runtime/test_signatureStream.cpp
> +++ b/test/hotspot/gtest/runtime/test_signatureStream.cpp
> @@ -22,6 +22,7 @@
>   */
> 
>  #include "precompiled.hpp"
> +#include "memory/resourceArea.hpp"
>  #include "runtime/interfaceSupport.inline.hpp"
>  #include "classfile/symbolTable.hpp"
>  #include "runtime/signature.hpp"
> @@ -85,4 +86,4 @@
> 
>    ASSERT_EQ(foo->refcount(), r1) << "refcount should have decremented";
> 
> -}
> \ No newline at end of file
> +}