RFR(T): 8239873: [TESTBUG] FieldLayout/OldLayoutCheck.java fails after the fix for JDK-8239503

[Frederic Parain]

Dan,

Thank you for fixing this test (again).
Looks good to me.

Fred


> On Feb 27, 2020, at 10:50, Daniel D. Daugherty <daniel.daugherty at oracle.com> wrote:
> 
> Greetings,
> 
> I'm trying to reduce the noise in the jdk/jdk CI. There is a trivial fix
> for this bug:
> 
>     JDK-8239873 [TESTBUG] FieldLayout/OldLayoutCheck.java fails after the fix for JDK-8239503
>     https://bugs.openjdk.java.net/browse/JDK-8239873
> 
> Thanks to David Holmes for suggesting looking for an @requires style fix.
> 
> Here's the context diff:
> 
> $ hg diff
> diff -r 57849c7f9d22 test/hotspot/jtreg/runtime/FieldLayout/OldLayoutCheck.java
> --- a/test/hotspot/jtreg/runtime/FieldLayout/OldLayoutCheck.java Wed Feb 26 19:41:39 2020 -0500
> +++ b/test/hotspot/jtreg/runtime/FieldLayout/OldLayoutCheck.java Thu Feb 27 10:48:22 2020 -0500
> @@ -28,7 +28,7 @@
>   * @library /test/lib
>   * @modules java.base/jdk.internal.misc
>   *          java.management
> - * @requires vm.bits == "64" & vm.gc != "Z"
> + * @requires vm.bits == "64" & vm.opt.final.UseCompressedOops == true & vm.gc != "Z"
>   * @run main/othervm -XX:+UseCompressedClassPointers -XX:-UseEmptySlotsInSupers OldLayoutCheck
>   */
> 
> 
> This fix has been verified via a Mach5 Tier7 job set. Without the fix,
> there are 18 runs of this test with 6 failures. With the fix, there are
> just the 12 passing runs of this test.
> 
> Thanks, in advance, for any comments, questions or suggestions.
> 
> Dan