RFR(S): 8239915: Zero VM crashes when handling dynamic constant

[David Holmes]

On 29/02/2020 10:33 am, Yangfei (Felix) wrote:
> Hi David,
> 
>      Thanks for the review.  Shall I do the push?

As this only affects Zero it is fine to push.

Thanks,
David

> Best regards,
> Felix
> 
>> -----Original Message-----
>> From: David Holmes [mailto:david.holmes at oracle.com]
>> Sent: Friday, February 28, 2020 10:16 AM
>> To: Yangfei (Felix) <felix.yang at huawei.com>;
>> hotspot-runtime-dev at openjdk.java.net
>> Subject: Re: RFR(S): 8239915: Zero VM crashes when handling dynamic
>> constant
>>
>> Hi Felix,
>>
>> On 27/02/2020 12:40 pm, Yangfei (Felix) wrote:
>>> New webrev: http://cr.openjdk.java.net/~fyang/8239915/webrev.01
>>>
>>> Does that look better?
>>
>> Test update looks good.
>>
>> I'm not clear on the index versus cache_index issue, but see now how it leads
>> to the failure. Calling InterpreterRuntime::resolve_ldc to always resolve is fine.
>>
>