RFR (XS) 8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match"

[coleen.phillimore at oracle.com]

On 1/14/20 3:45 PM, Leonid Mesnik wrote:
> Hi
>
> The fix looks good itself (you still need 'R'eview). However I see 
> about 20 other SA/ tests where lingeredApp is still executed with 
> vm.opts only. Even it doesn't cause any failures it means that tests 
> silently ignore java.opts set by user.
>
> I think it makes sense to fix them also or file new issue for this 
> activity.


I'll file another bug for the other instances.  I'm not sure that maybe 
we want to remove getVmOptions() with that bug, so as not to trick 
anyone else.

Thanks,
Coleen
>
> Leonid
>
> On 1/14/20 11:38 AM, coleen.phillimore at oracle.com wrote:
>> Summary: Use getTestJavaOpts() instead of getVmOptions() because of 
>> mach5 configuration settings.
>>
>> Tested with hs-tier3 with no failures anymore.
>>
>> open webrev at 
>> http://cr.openjdk.java.net/~coleenp/2020/8236917.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8236917
>>
>> Thanks,
>> Coleen