RFR(s): 8236766: Remove un-used oops do and drain list in VM thread.

Robbin Ehn robbin.ehn at oracle.com
Thu Jan 16 07:32:51 UTC 2020


Hi Coleen,

On 2020-01-10 20:07, coleen.phillimore at oracle.com wrote:
> 
> Robbin, this looks good.  I was looking for where we used to have oops in VM_Operation (it was VM_ThreadStop), which is 
> now a handshake.  So this is good.  This line should have also been removed though:
> 

Thanks!

> $ grep -ri threadstop
> share/runtime/vmOperations.hpp:  template(ThreadStop)
> $
> 
> Can you remove this too?

Yes!

/Robbin

> 
> Thanks,
> Coleen
> 
> On 1/10/20 4:35 AM, Robbin Ehn wrote:
>> Hi all, please review.
>>
>> We have removed all oops and oops do from the VM operations.
>> We can now remove the oops do on VM op base class, oops do on VM queue and the drain list.
>>
>> Note that I also removed the unused VMOperationQueue::verify_queue.
>>
>> Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8236766
>>
>> Changeset:
>> http://cr.openjdk.java.net/~rehn/8236766/v1/webrev/index.html
>>
>> Passes t1-3.
>>
>> Thanks, Robbin
> 


More information about the hotspot-runtime-dev mailing list