[aarch64-port-dev ] RFR(S): 8236992: AArch64: remove redundant load_klass in itable stub

[Andrew Haley]

On 1/16/20 9:48 AM, Nick Gasson wrote:
> On 16/01/2020 17:45, Andrew Dinn wrote:
>> The code changes look ok to me.
>>
>> Did you test it? :-)
>>
> Yes, sorry! I forgot to add that to the RFR:
> 
> Tested jtreg hotspot_all_no_apps, jdk_core with no new failures and a 
> fastdebug build to check the assert(slop_delta >= 0) doesn't fail.

This comment is a "what" but not a "why":

-  // Most registers are in use; we'll use r16, rmethod, r10, r11
+  // This stub is called from compiled code which has no callee-saved registers.

It might be better to say that all registers except args are free at
this point.

The lack of such a comment once cause Andrew Dinn and me to spend a
week debugging. :-(

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671