RFR: 8237752: Minimal VM build fails after JDK-8236236

[jiefu(傅杰)]

Thank you so much, David.


On 2020/1/23, 2:24 PM, "David Holmes" <david.holmes at oracle.com> wrote:

    Hi Jie,
    
    Yes I can sponsor.
    
    David
    
    On 23/01/2020 4:04 pm, jiefu(傅杰) wrote:
    > Hi David,
    > 
    > Thanks for your review.
    > 
    > The patch has been ready in the attachment.
    > I can't push it since my ssh-public key hasn't been updated on the openjdk server.
    > Could you please sponsor it?
    > 
    > Thanks a lot.
    > Best regards,
    > Jie
    > 
    > 
    > On 2020/1/23, 1:11 PM, "David Holmes" <david.holmes at oracle.com> wrote:
    > 
    >      Hi Jie,
    >      
    >      Fix looks good and trivial.
    >      
    >      Thanks,
    >      David
    >      
    >      On 23/01/2020 12:06 pm, jiefu(傅杰) wrote:
    >      > Hi all,
    >      >
    >      >
    >      >
    >      > JBS: https://bugs.openjdk.java.net/browse/JDK-8237752
    >      >
    >      >
    >      >
    >      > May I get reviews for this tiny fix?
    >      >
    >      > -----------------------------------------------------------------------
    >      >
    >      > diff -r 36218eab4255 src/hotspot/share/memory/metaspaceShared.hpp
    >      >
    >      > --- a/src/hotspot/share/memory/metaspaceShared.hpp      Wed Jan 22 20:07:49 2020 -0500
    >      >
    >      > +++ b/src/hotspot/share/memory/metaspaceShared.hpp      Thu Jan 23 09:44:46 2020 +0800
    >      >
    >      > @@ -360,8 +360,10 @@
    >      >
    >      >
    >      >
    >      >     static void write_core_archive_regions(FileMapInfo* mapinfo);
    >      >
    >      >   private:
    >      >
    >      > +#if INCLUDE_CDS
    >      >
    >      >     static void write_region(FileMapInfo* mapinfo, int region_idx, DumpRegion* dump_region,
    >      >
    >      >                              bool read_only,  bool allow_exec);
    >      >
    >      > +#endif
    >      >
    >      >     static void read_extra_data(const char* filename, TRAPS) NOT_CDS_RETURN;
    >      >
    >      >     static FileMapInfo* open_static_archive();
    >      >
    >      >     static FileMapInfo* open_dynamic_archive();
    >      >
    >      > -----------------------------------------------------------------------
    >      >
    >      >
    >      >
    >      > Thanks a lot.
    >      >
    >      > Best regards,
    >      >
    >      > Jie
    >      >
    >      
    >      
    >