RFR(T) 8248886 InstanceKlass::initialize_impl crashes with -XX:-UsePerfData after JDK-8246019

Ioi Lam ioi.lam at oracle.com
Tue Jul 7 00:53:43 UTC 2020


Thanks Calvin! Pushed.

- Ioi

On 7/6/20 5:31 PM, Calvin Cheung wrote:
> Hi Ioi,
>
> The fix looks good and it seems trivial.
>
> thanks,
>
> Calvin
>
> On 7/6/20 5:01 PM, Ioi Lam wrote:
>> Hi, here's a quick fix for a crash that happens with "java 
>> -XX:-UsePerfData -version"
>>
>> $ hg diff
>> diff -r d90de88ba4d0 src/hotspot/share/oops/instanceKlass.cpp
>> --- a/src/hotspot/share/oops/instanceKlass.cpp    Mon Jul 06 15:14:44 
>> 2020 -0700
>> +++ b/src/hotspot/share/oops/instanceKlass.cpp    Mon Jul 06 17:00:52 
>> 2020 -0700
>> @@ -1169,7 +1169,9 @@
>>        call_class_initializer(THREAD);
>>      } else {
>>        // The elapsed time is so small it's not worth counting.
>> -      ClassLoader::perf_classes_inited()->inc();
>> +      if (UsePerfData) {
>> +        ClassLoader::perf_classes_inited()->inc();
>> +      }
>>        call_class_initializer(THREAD);
>>      }
>>    }
>>
>>
>> Thanks
>> - Ioi
>>
>>



More information about the hotspot-runtime-dev mailing list