RFR: 8250598: Hyper-V is detected in spite of running on host OS

[David Holmes]

On 27/07/2020 2:24 pm, Yasumasa Suenaga wrote:
> Hi all,
> 
> Please review this change:
> 
>    JBS: https://bugs.openjdk.java.net/browse/JDK-8250598
>    webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8250598/webrev.00/
> 
> When I got hs_err log on Windows, I saw "HyperV virtualization detected" 
> in it in spite of running on host OS.
> 
> Hypervisor detector has been introduced in JDK-8219241, but it has some 
> problems as below:
> 
>    - Hyper-V is detected on Windows in spite of running on host OS
>    - Call CPUID with other than EAX = 40000000h (it is not described in 
> the spec [1])

That VMWare document is not a "spec" for anything other than VMware. So 
this may work for VMWare:

   a->movl(rax, 0x40000000);

but may not work for all other HV environments - which is why the 
original code checks a range of addresses within the reserved area. See 
this related code for example:

http://git.annexia.org/?p=virt-what.git;a=blob;f=virt-what-cpuid-helper.c;h=9c6cdb290105ca86868e2c7935ed42a55598b0f7;hb=HEAD

   71   /* Most hypervisors only have information in leaf 0x40000000.
   72    *
   73    * Some hypervisors have "Viridian [HyperV] extensions", and those
   74    * must appear in slot 0x40000000, but they will also have the true
   75    * hypervisor in a higher slot.

You have to be able to check this on a range of HV's to ensure you have 
not broken anything.

Did you actually diagnose why the existing code mis-detects Hyper-V 
under Windows?

David
-----

>    - Does not check CPUID hypervisor present bit [1]
>    - Does not support x86 (32bit) platform
> 
> I've tested this change on submit repo, and have checked output from 
> VM.info jcmd on following environment:
> 
>    - Windows x64 (host)
>    - Windows x64 (Hyper-V guest)
>    - Fedora32 x64 (Hyper-V guest)
>    - 32 bit JDK on Fedora32 x64 (Hyper-V guest)
> 
> 
> Thanks,
> 
> Yasumasa
> 
> 
> [1] https://kb.vmware.com/s/article/1009458