RFR: 8248817: Windows: Improving common cross-platform code

[Ludovic Henry]

Perfect, thank you!

-----Original Message-----
From: David Holmes <david.holmes at oracle.com> 
Sent: Wednesday, July 29, 2020 5:34 PM
To: Ludovic Henry <luhenry at microsoft.com>; Kim Barrett <kim.barrett at oracle.com>
Cc: hotspot-runtime-dev at openjdk.java.net; openjdk-aarch64 <openjdk-aarch64 at microsoft.com>
Subject: Re: RFR: 8248817: Windows: Improving common cross-platform code

Pushed.

David

On 29/07/2020 7:30 pm, David Holmes wrote:
> Hi Ludovic,
> 
> I was on vacation today but back tomorrow (13 hours from this email) and 
> I can sponsor this if Kim doesn't get there first. :)
> 
> Cheers,
> David
> 
> On 29/07/2020 2:26 am, Ludovic Henry wrote:
>> Hi Kim, David,
>>
>> A quick follow-up on that change. Anything else you'd like to see 
>> changed? If not, could one of you please sponsor for it to be merged? 
>> Let me know of anything I should do to get it merged.
>>
>> Thank you
>> Ludovic
>>
>> ________________________________________
>> From: Ludovic Henry <luhenry at microsoft.com>
>> Sent: Friday, July 17, 2020 11:26
>> To: Kim Barrett
>> Cc: David Holmes; hotspot-runtime-dev at openjdk.java.net; openjdk-aarch64
>> Subject: Re: RFR: 8248817: Windows: Improving common cross-platform code
>>
>> Hi Kim,
>>
>> I've updated the webrev at 
>> https://nam06.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openjdk.java.net%2F~burban%2Fluhenry%2F8248817-atomics%2Fwebrev.04&data=02%7C01%7Cluhenry%40microsoft.com%7C948a308e467b438d34c208d834204db4%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637316660633998158&sdata=u8nbJRe692lkuRN4GJvTgAZVDpQzD%2F%2F3MEpDqBodtjg%3D&reserved=0 
>> with these spacing fixes.
>>
>> ________________________________________
>> From: Kim Barrett <kim.barrett at oracle.com>
>> Sent: Thursday, July 16, 2020 18:43
>> To: Ludovic Henry
>> Cc: David Holmes; hotspot-runtime-dev at openjdk.java.net; openjdk-aarch64
>> Subject: Re: RFR: 8248817: Windows: Improving common cross-platform code
>>
>>> On Jul 16, 2020, at 6:00 PM, Ludovic Henry <luhenry at microsoft.com> 
>>> wrote:
>>>
>>> I've upload these latest changes to 
>>> https://nam06.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openjdk.java.net%2F~burban%2Fluhenry%2F8248817-atomics%2Fwebrev.04&data=02%7C01%7Cluhenry%40microsoft.com%7C948a308e467b438d34c208d834204db4%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637316660633998158&sdata=u8nbJRe692lkuRN4GJvTgAZVDpQzD%2F%2F3MEpDqBodtjg%3D&reserved=0 
>>>
>>
>> The change from "StubName" => "IntrinsicName" made the indenting of
>> arguments in the calls no longer lined up normally. Line 65, line 82,
>> and lines 104-5 are now abnormally indented.
>>
>> Other than that, looks good.  I don't need another webrev for a fix of
>> the indentation.
>>