RFR: 8248817: Windows: Improving common cross-platform code

David Holmes david.holmes at oracle.com
Thu Jul 30 06:56:45 UTC 2020


Changeset: c35fba4bce35
Author:    dholmes
Date:      2020-07-30 02:47 -0400
URL:       https://hg.openjdk.java.net/jdk/jdk/rev/c35fba4bce35

8250810: Push missing parts of JDK-8248817
Summary: Push changes from JDK-8248817 that were accidentally excluded 
from the commit.
Reviewed-by: kbarrett, dholmes
Contributed-by: Ludovic Henry <luhenry at microsoft.com>

! src/hotspot/os/windows/os_windows.cpp
! src/hotspot/os_cpu/windows_x86/thread_windows_x86.cpp


On 30/07/2020 4:40 pm, David Holmes wrote:
> Hi Ludovic,
> 
> On 30/07/2020 11:45 am, Ludovic Henry wrote:
>> Hi David,
>>
>> Looking at the change pushed [1], it seems like you pushed only part 
>> of the whole change (the bits related to atomics). It's missing the 
>> other two webrevs linked in the first email ([2] and [3]). What would 
>> be the best way to proceed? Would you like me to submit another review?
> 
> Aaarghhh! Sorry. I'll file a new bug and push the other bits under it.
> 
> David
> 
>> Thanks,
>> Ludovic
>>
>> [1] https://hg.openjdk.java.net/jdk/jdk/rev/bda65def14de
>> [2] 
>> http://cr.openjdk.java.net/~burban/luhenry/8248817-exception-handling/
>> [3] http://cr.openjdk.java.net/~burban/luhenry/8248817-frames/
>>


More information about the hotspot-runtime-dev mailing list