RFR (trivial): 8247388: Minimal build broken after JDK-8240245 (undefined reference to `MetaspaceShared::_use_optimized_module_handling')

[David Holmes]

On 11/06/2020 9:55 pm, coleen.phillimore at oracle.com wrote:
> 
> On further viewing, I think adding NOT_CDS_RETURN to
> 
> MetaspaceShared::disable_optimized_module_handling();
> 
> would be a lot better actually.

That's fine by me to get this fixed for the build. But what Ao Qi has 
highlights that this code is IMO in the wrong place to begin with. This 
logic should be in Arguments::create_module_property not the general 
purpose Arguments::add_property. I will file a follow up bug to address 
that.

Thanks,
David

> Coleen
> 
> On 6/11/20 7:53 AM, coleen.phillimore at oracle.com wrote:
>> This looks good and trivial.
>> thanks,
>> Coleen
>>
>> On 6/11/20 6:15 AM, Ao Qi wrote:
>>> Hi all,
>>>
>>> Could you please review this patch?
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8247388
>>> webrev: http://cr.openjdk.java.net/~aoqi/8247388/webrev.00/
>>>
>>> Thanks,
>>> Ao Qi
>>>
>>
>