RFR (S): 8247292 and 8247289: obsolete BSD command-line flags

[David Holmes]

Thanks Dan!

David

On 16/06/2020 12:07 am, Daniel D. Daugherty wrote:
> On 6/15/20 9:03 AM, David Holmes wrote:
>> A two for the price of one special offer ;-)
>>
>> Two unused flags (copied from the Linux port) are made obsolete in JDK 
>> 16 and ready for expiration in JDK 17.
>>
>> 8247289: Obsolete unused UseBsdPosixThreadCPUClocks
>> https://bugs.openjdk.java.net/browse/JDK-8247289
>> Contributed by: Christoph Dreis <christoph.dreis at freenet.de>
>>
>> This flag is only declared in globals_bsd.hpp.
>>
>> 8247292: Obsolete unused UseOprofile flag on BSD
>> https://bugs.openjdk.java.net/browse/JDK-8247292
>>
>> This is "used" in bsd_wrap_code, which is itself an unused copy of 
>> linux_wrap_code.
>>
>> combined webrev:
>>
>> http://cr.openjdk.java.net/~dholmes/8247292-8247289/webrev/
> 
> src/hotspot/os/bsd/globals_bsd.hpp
>      No comments.
> 
> src/hotspot/os/bsd/os_bsd.cpp
>      No comments.
> 
> src/hotspot/share/runtime/arguments.cpp
>      No comments.
> 
> Thumbs up.
> 
> Dan
> 
> 
>>
>> Both issues have approved CSR requests.
>>
>> Testing:
>>  - builds in tiers 1-3
>>  - sanity testing of tiers 1-3
>>  - manual checking that the flags report as obsolete:
>>
>> > ./jdk-16/fastdebug/bin/java -XX:+UseOprofile -version
>> Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option 
>> UseOprofile; support was removed in 16.0
>> java version "16-internal" 2021-03-16
>> Java(TM) SE Runtime Environment (fastdebug build 
>> 16-internal+0-2020-06-15-1146345.david.holmes.jdk-dev)
>> Java HotSpot(TM) 64-Bit Server VM (fastdebug build 
>> 16-internal+0-2020-06-15-1146345.david.holmes.jdk-dev, mixed mode, 
>> sharing)
>> > ./jdk-16/fastdebug/bin/java -XX:+UseBsdPosixThreadCPUClocks -version
>> Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option 
>> UseBsdPosixThreadCPUClocks; support was removed in 16.0
>> java version "16-internal" 2021-03-16
>> Java(TM) SE Runtime Environment (fastdebug build 
>> 16-internal+0-2020-06-15-1146345.david.holmes.jdk-dev)
>> Java HotSpot(TM) 64-Bit Server VM (fastdebug build 
>> 16-internal+0-2020-06-15-1146345.david.holmes.jdk-dev, mixed mode, 
>> sharing)
>>
>>
>> Thanks,
>> David
>> -----
>