RFR (S) 8248240: Remove extendedPC.hpp and fetch_frame_from_ucontext

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Wed Jun 24 23:17:09 UTC 2020



On 6/24/20 7:11 PM, David Holmes wrote:
> Hi Coleen,
>
> This cleanup looks good - thanks.
>
> My only query (from existing code) is why something called 
> "fetch_frame" doesn't actually return a frame ??

Thanks David.

http://cr.openjdk.java.net/~coleenp/2020/8248240.01/webrev/src/hotspot/os_cpu/aix_ppc/os_aix_ppc.cpp.udiff.html

Looks like one of these overloads does return the frame, and the other 
returns the pieces of a frame.  No idea.

Thanks
Coleen

>
> Thanks,
> David
>
> On 25/06/2020 7:08 am, coleen.phillimore at oracle.com wrote:
>> Summary: This empty interface was left over from deleting code from 
>> before safepoint polling.
>>
>> See bug for details.  Ran tier1-3, and also builds on ppc, aarch64, 
>> arm, s390, and zero.
>>
>> open webrev at 
>> http://cr.openjdk.java.net/~coleenp/2020/8248240.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8248240
>>
>> Thanks,
>> Coleen



More information about the hotspot-runtime-dev mailing list