RFR: 8240263: Assertion-only call in Method::link_method affecting product builds

[Aleksey Shipilev]

On 3/2/20 10:22 AM, Claes Redestad wrote:
> Guarding the resolution by DEBUG_ONLY seem the right thing to do here,
> which bring a small improvement on startup tests when CDS is enabled.
> 
> See attached patch[1].

I believe we usually do this in such case:

#ifdef ASSERT
  address entry = Interpreter::entry_for_cds_method(h_method);
  assert(entry != NULL && entry == _i2i_entry,
         "should be correctly set during dump time");
#endif

It keeps the block easily editable, without looking back at whether it interferes with macros.

Otherwise looks fine, assuming release builds still pass.

-- 
Thanks,
-Aleksey