RFR(XS): 8240691: serviceability/sa/ClhsdbCDSJstackPrintAll.java and serviceability/sa/ClhsdbCDSCore.java should be excluded with ZGC

[Yumin Qi]

HI, Chris

  After discussed with Ioi, we found there are bugs in the test lib and 
this test case:

  1) The test lib, LingeredApp did not pass getTestJavaOp0ts()  to the 
children process if vmArguments is already specified.
http://hg.openjdk.java.net/jdk/jdk/file/3465ed78d670/test/lib/jdk/test/lib/apps/LingeredApp.java#l307

  2) The check in the test code: (ClhsdbCDSJstackPrintAll.java) should 
be changed:

   72             if (!useSharedSpacesOutput.contains("true")) {
   73                 // CDS archive is not mapped. Skip the rest of the test.
   74                 LingeredApp.stopApp(theApp);
   75                 throw new SkippedException("The CDS archive is not mapped");
   76             }
   77

     if (useSharedSpacesOutput.contains("UseSharedSpaces = false")) {

   This will cause the test skipped. I will file a bug for 1) and will 
post webrev for this bug next.

   The java opts not passed into children will cause the parameters used 
in dump/run inconsistent.

Thanks

Yumin

3/6/20 3:01 PM, Chris Plummer wrote:

> Hi Yumin,
>
> Why do these tests not work with ZGC? Is there a bug filed for that?
>
> thanks,
>
> Chris
>
> On 3/6/20 2:26 PM, Yumin Qi wrote:
>> HI,
>>
>>   Can I have your reviews on
>>
>>   Bug: https://bugs.openjdk.java.net/browse/JDK-8240691
>>
>>   webrev: http://cr.openjdk.java.net/~minqi/8240691/webrev/
>>
>>   Summary: With JDK-8232069 
>> (https://bugs.openjdk.java.net/browse/JDK-8232069), CDS works with 
>> UseCompressedOop and UseCompressedClassPointers off. The code for 
>> detecting CDS will report false with ZGC since ZGC turned off those 
>> two flags. The detection code will be changed in 
>> JDK-8240563(https://bugs.openjdk.java.net/browse/JDK-8240563), this 
>> will cause those two tests fail.
>>
>>
>>    Tests: jtreg to show the tests not selected with ZGC.
>>
>>    Thanks
>>
>>    Yumin
>>
>
>