RFR(XS) 8240548 [TESTBUG] CDS NoClassToArchive.java fails with Graal

[David Holmes]

Looks good.

Thanks,
David

On 11/03/2020 2:30 am, Ioi Lam wrote:
> 
> 
> On 3/8/20 10:41 PM, David Holmes wrote:
>> Hi Ioi,
>>
>> On 9/03/2020 2:52 pm, Ioi Lam wrote:
>>> https://bugs.openjdk.java.net/browse/JDK-8240548
>>> http://cr.openjdk.java.net/~iklam/jdk15/8240548-NoClassToArchive.graal.v01/ 
>>>
>>>
>>> This test should not be executed with graal.
>>>
>>> This test started failing in valhalla/nestmate because the string
>>> "unsafe anonymous" is no longer printed by -Xlog:class+load=trace. 
>>> However,
>>> the underlying problem is unrelated to nestmate. So I will fix the 
>>> test in
>>> the mainline jdk/jdk and it can be synced down to nestmate.
>>>
>>> The test assumes that when "java -version" is executed, only a very 
>>> limited
>>> number of classes are loaded, and all of those are loaded from the 
>>> default
>>> shared archive.
>>>
>>> However, when graal is used as the JIT, many extra classes are loaded
>>> during VM start-up. Some of those are loaded dynamically from jrt:/.
>>> Some classes are also defined by LambdaMetafactory. This causes 
>>> complexity
>>> that cannot be easily handled by this test.
>>>
>>> The VM code covered by this test can be sufficiently tested with 
>>> C1/C2. So
>>> there's no need to bend over backwards to run this test with graal.
>>
>> Okay. I'd probably have that explanatory comment up the top of the 
>> file rather than within doTest(), but that's just a nit.
>>
> 
> Hi David,
> 
> I moved the comments into the top of the file:
> 
> http://cr.openjdk.java.net/~iklam/jdk15/8240548-NoClassToArchive.graal.v02/
> 
> Thanks
> - Ioi
> 
>> Thanks,
>> David
>>
>>> Thanks
>>> - Ioi
>