RFR(S): 8240563: [TESTBUG] WB_IsCDSIncludedInVmBuild should support uncompressed oops/klasses

Yumin Qi yumin.qi at oracle.com
Thu Mar 12 15:59:18 UTC 2020


Hi, Ioi

   Thanks for the review!

Yumin

On 3/11/20 9:52 PM, Ioi Lam wrote:
> Hi Yumin,
>
> Looks good to me.
>
> Thanks!
>
> - Ioi
>
> On 3/11/20 4:47 PM, Yumin Qi wrote:
>> Hi,
>>   Please review:
>>   bug: https://bugs.openjdk.java.net/browse/JDK-8240563
>>   url: http://cr.openjdk.java.net/~minqi/8240563/webrev-00/
>>
>>   Summary: With bug fix of 8232069 
>> (https://bugs.openjdk.java.net/browse/JDK-8232069) 
>> <https://bugs.openjdk.java.net/browse/JDK-8232069> pushed, CDS now 
>> works with UserCompressedOops on/off (also 
>> UseCompressedClassPointers). The detecting of CDS should not rely on 
>> the two flags.
>>
>>  test/hotspot/jtreg/runtime/cds/appcds/CommandLineFlagComboNegative.java 
>> :
>>      Mark for non-ZGC since ZGC will turn off UseCompressedOops and 
>> UseCompressedClassPointers so will mess up the flag combination.
>>  serviceability/sa/ClhsdbCDSCore.java will fail with the fix:
>>      The core file generated with UseZGC but currently SA does not 
>> work with ZGC. so add it to test/hotspot/jtreg/ProblemList-zgc.txt
>>   test/hotspot/jtreg/runtime/cds/appcds/TestZGCWithCDS.java:
>>      Explicitly add options which could be changed by ZGC.
>>
>>    Tests: hs-tier1,hs-tier2, hs-tier3
>>
>> Thanks
>> Yumin
>



More information about the hotspot-runtime-dev mailing list