RFR (S): 8239593: Bogus warning "Re-registering of platform native method" for a JVMTI agent

[Alan Bateman]

On 17/03/2020 08:48, David Holmes wrote:
> On 17/03/2020 6:35 pm, Alan Bateman wrote:
>> On 16/03/2020 23:12, David Holmes wrote:
>>> Can I get a second review please.
>> The approach and changes look okay to me. I see in your reply to Dan 
>> that you tweaking the comment. One additional nit is is the existing 
>> "But we issue ..." is an unusual sentence as the reason for emitting 
>> the warning isn't explained in the sentence. Might be simplest to 
>> just drop the "But".
>
> Thanks Alan.
>
> The "But ..." serves as a special condition in relation to the "There 
> are no restrictions ...". The grammar is probably not the best there. 
> This:
>
> " ... native methods. But we issue ..."
>
> should probably be:
>
> " ...native methods, however we issue ..."
That works for me.

-Alan.