RFR(XS): 8241009: CommandLineFlagComboNegative.java fails after JDK-8240563

[Yumin Qi]

Hi, David
   I have updated the web, I missed -XX:+UnlockDiagnosticVMOptions 
-XX:+WhiteBoxAPI --- this will cause on some platform(Windows) linkage 
Error.
   It passed locally due to !vm.gc.Z which will not be selected when run 
with ZGC. Now it will skip ZGC with checkSkip().

On 3/17/20 9:52 PM, David Holmes wrote:
> Hi Yumin,
>
> On 18/03/2020 9:01 am, Yumin Qi wrote:
>> Hi, please review
>>
>>    Bug:https://bugs.openjdk.java.net/browse/JDK-8241009 
>> <https://bugs.openjdk.java.net/browse/JDK-8241009>
>>    Webrev: http://cr.openjdk.java.net/~minqi/8241009/webrev/
>>
>>    The vmoptions from jtreg still affect the launched processes and 
>> mess up the parameters for launched java processes in the test.
>>    Fix skip the test if -XX:-UseCompressedOops or 
>> -XX:-UseCompressedClassPointers in jtreg vmoptions (or javaoptions).
>
> I can think of a couple of different ways to try and account for this 
> problem, none of which stands out to me as the best way, so using 
> whitebox to skip the test seems okay.
>
> Ideally we would have a simple way to filter the passed through 
> options so that we could remove problematic ones for a given test, or 
> add new flags to override the problematic ones.
>
Yes, agree. Should we suggest test coding with some rules such like:
if the test not launching process, like @run main/.. <flags> TestCaste, 
the options specified in <falgs> by the author.
if the test launching process, the test frame filter out the vmoptions. 
The cases in appcds are more like this. The children processes launched 
with their own vm options, jtreg options will mess them up. I think bug 
https://bugs.openjdk.java.net/browse/JDK-8240698 should handle this.
The best solution maybe, just run jtreg without vmoptions, let the 
author name them in the tests either @run or supplying options to 
children processes.

Thanks
Yumin
> Thanks,
> David
> -----
>
>>    Tests: tested with explicitly set -XX:-UseCompressedOops or 
>> -XX:-UseCompressedClassPointers or both in jtreg vmoptions.
>>    tier1,2,4,7 test pending.
>>
>> Thanks
>> Yumin