RFR (XS) 8241500: FieldLayout/OldLayoutCheck.java fails in 32-bit VMs
Aleksey Shipilev
shade at redhat.com
Tue Mar 24 14:00:10 UTC 2020
On 3/24/20 2:51 PM, David Holmes wrote:
> On 24/03/2020 11:19 pm, Frederic Parain wrote:
> I'm somewhat surprised that it has taken 4 weeks for this problem on
> 32-bit to be noticed! :(
Nobody has time to look at auxiliary CIs in the midst of pandemic!
> A comment as to why INT_OFFSET and LONG_OFFSET have those values would
> be good. Otherwise fix is fine by me too.
I'll do this:
+ // 32-bit VMs: @0: 8 byte header, @8: long field, @16: int field
+ // 64-bit VMs: @0: 12 byte header, @12: int field, @16: long field
+ static final long INT_OFFSET = Platform.is64bit() ? 12L : 16L;
+ static final long LONG_OFFSET = Platform.is64bit() ? 16L : 8L;
Reasonable?
--
Thanks,
-Aleksey
More information about the hotspot-runtime-dev
mailing list