RFR: 8241427: Coarsen locking in Modules::add_module_exports

[Harold Seigel]

I'm okay with the change as is.

Thanks, Harold

On 3/25/2020 2:49 PM, Claes Redestad wrote:
> Not at all difficult, basically go back to open.00 and fix the things
> that doesn't change the interatction. But this difference is only
> observable when using the WhiteBox API to call into
> JVM_AddModuleExports* - all public APIs like Module.addExports(String,
> Module) will throw an IAE as usual (with tests to check that).
>
> I'm ok with dialing this RFE back a notch and file a follow-up for that,
> though.
>
> /Claes
>
> On 2020-03-25 19:33, Harold Seigel wrote:
>> How difficult would it be to restore the IAE?
>>
>> Thanks, Harold
>>
>> On 3/25/2020 2:17 PM, Claes Redestad wrote:
>>> Hi,
>>>
>>> On 2020-03-25 18:48, Harold Seigel wrote:
>>>> Hi Claes,
>>>>
>>>> It looks like you removed this from modules.cpp.  Can you also 
>>>> remove it from modules.hpp?
>>>>
>>>>     Modules::get_module(Symbol* package_name, Handle h_loader, TRAPS)
>>>
>>> Done.
>>>
>>>>
>>>> Otherwise, the change looks good.
>>>
>>> I also updated the webrev to remove 2 tests that poke at the internal
>>> API to provoke the IAE we'll no longer be throwing. I'll need to check
>>> if there's any other fallout from higher tiers - or if we should dial
>>> this back a bit...
>>>
>>> /Claes