RFR[T, urgent]: 8241723: Build error after 8241581

Kim Barrett kim.barrett at oracle.com
Fri Mar 27 07:41:22 UTC 2020


> On Mar 27, 2020, at 3:25 AM, Thomas Stüfe <thomas.stuefe at gmail.com> wrote:
> 
> Hi,
> 
> not my proudest day.
> 
> <https://bugs.openjdk.java.net/browse/JDK-8241723>
> Gtest for 8241581 got added accidentally after running the tests but before
> the push. Immediate result is an escaped build error in release:
> 
> /shared/projects/openjdk/jdk-jdk/source/test/hotspot/gtest/utilities/test_bitMap_popcnt.cpp:
> In destructor 'ErrorDetailsPrinter::~ErrorDetailsPrinter()':
> /shared/projects/openjdk/jdk-jdk/source/test/hotspot/gtest/utilities/test_bitMap_popcnt.cpp:96:11:
> error: 'class BitMap' has no member named 'print_on'
> 
> but since there may be other errors in this gtest as well, I'd like to
> remove the test, re-run all tests, then re-add it.
> 
> The tested functionality is still unused, so we need not to roll-back the
> whole patch.
> 
> https://bugs.openjdk.java.net/browse/JDK-8241723
> 
> Fix consists of "hg
> remove test/hotspot/gtest/utilities/test_bitMap_popcnt.cpp", so there is no
> webrev.
> 
> Thanks, Thomas

Looks good, and trivial.



More information about the hotspot-runtime-dev mailing list