RFR (XS): 8236177: assert(status == 0) failed: error ETIMEDOUT(60), cond_wait

[gerard ziemski]

Thnak you David for your feedback!

On 3/25/20 6:43 PM, David Holmes wrote:
> Hi Gerard,
>
> On 26/03/2020 4:03 am, gerard ziemski wrote:
>> hi all,
>>
>> Please review this "workaround" for now, which can not be called an 
>> actual fix just yet, designed to figure out why on Mac OS X, we get 
>> (very rarely) ETIMEDOUT when calling pthread_cond_wait() API. On 
>> other hand, it might actually fix it.
>
> The ETIMEDOUT should be treated as a "spurious wakeup" and we will 
> naturally retry the wait if the condition is not yet met. All we have 
> to do to our code is adjust the assert so that ETIMEDOUT doesn't cause 
> it to fail.

My initial approach, as I noted in the bug, was to do exactly that, but 
when you commented in the bug, that we used to run into these kinds of 
issues before, and used to have workarounds in place for that, it made 
me worry that we will do again the workaround, and at some point in the 
future we remove it again, and we will back to square one.

I was hoping that now we do something to get a better sense of what the 
underlying issue is, which is why I proposed this change instead.

Is that OK?

If you really want us to do what you suggest, then would you mind 
sharing what you remember about the previous workaround, and why it was 
removed? If anyone else remembers anything about it, hen please share 
here as well.


cheers