RFR(S): 8241101: [s390] jtreg test failure after JDK-8238696: not conformant features string

[Doerr, Martin]

Hi Thomas,

I agree with that.

test/lib/sun/hotspot/cpuinfo/CPUInfo.java uses
return features.contains(feature.toLowerCase());
in "hasFeature" which is not nicely designed.

If it is required to lower the case (for some reason), I think it should better use
features.contains(feature) || features.contains(feature.toLowerCase())

Or even better if we don't need toLowerCase at all and fix the strings.

Anyway, the 2nd part of the change (SHA, AES, ...) looks good to me.

Best regards,
Martin


> -----Original Message-----
> From: hotspot-runtime-dev <hotspot-runtime-dev-
> bounces at openjdk.java.net> On Behalf Of Thomas Stüfe
> Sent: Dienstag, 31. März 2020 10:01
> To: Schmidt, Lutz <lutz.schmidt at sap.com>
> Cc: hotspot-runtime-dev at openjdk.java.net
> Subject: Re: RFR(S): 8241101: [s390] jtreg test failure after JDK-8238696: not
> conformant features string
> 
> HI Lutz,
> 
> Should we not better adjust the jtreg test?
> 
> Cheers, Thomas
> 
> On Tue, Mar 31, 2020 at 9:22 AM Schmidt, Lutz <lutz.schmidt at sap.com>
> wrote:
> 
> > Dear All,
> >
> > may I please request reviews for this fix, adjusting the CPU features
> > string such that jtreg tests, in particular a newly introduced one, pass OK.
> >
> > Bug:    https://bugs.openjdk.java.net/browse/JDK-8241101
> > Webrev: https://cr.openjdk.java.net/~lucy/webrevs/8241101.00/
> >
> > Thank you!
> > Lutz
> >
> >
> >
> >