RFR: 8241837: Cleanup stringStream usage in ObjectSynchronizer

Daniel D. Daugherty daniel.daugherty at oracle.com
Tue Mar 31 14:09:01 UTC 2020


On 3/30/20 7:02 PM, Claes Redestad wrote:
> Hi,
>
> this removes one unused stringStream, and refactors two other
> so that they're only defined in the slow path error where they are used:
>
> http://cr.openjdk.java.net/~redestad/8241837/open.00/

src/hotspot/share/runtime/synchronizer.cpp
     No comments.

Just FYI: ObjectMonitor::is_busy_to_string() calls stringStream::base()
so the cleanup is handled by the stringStream destructor. I didn't want
ResourceMarks.

Thumbs up.

Dan


>
> While a very small startup performance gain (removes ~50k instructions
> on a Hello World), these stringStreams mallocs on init, which could be
> problematic at times in this particular area.
>
> Thanks!
>
> /Claes



More information about the hotspot-runtime-dev mailing list