RFR(S/T) : 8243433 : use reproducible random in :vmTestbase_nsk_sysdict

Igor Ignatyev igor.ignatyev at oracle.com
Fri May 1 16:31:38 UTC 2020



> On Apr 30, 2020, at 9:27 PM, David Holmes <david.holmes at oracle.com> wrote:
> 
> On 1/05/2020 1:58 pm, Igor Ignatyev wrote:
>> Thanks David!
>> and I guess it also looks trivial so I can push it right away, right?
> 
> I assume so. I don't know how this key actually gets used by jtreg :)
pushed. this k/w is used by jtreg in the same way as 'intermittent' -- it's just an informative k/w, nor jtreg nor our test execution infrastructure use it, the only usage is in reporting, where you can clearly see that the test is known not be stable to itself.

-- Igor

> 
> David
> 
>> -- Igor
>>> On Apr 30, 2020, at 7:49 PM, David Holmes <david.holmes at oracle.com> wrote:
>>> 
>>> This one looks good. :)
>>> 
>>> Thanks,
>>> David
>>> 
>>> On 1/05/2020 3:27 am, Igor Ignatyev wrote:
>>>> http://cr.openjdk.java.net/~iignatyev/8243433/webrev.00
>>>>> 40 lines changed: 0 ins; 0 del; 40 mod;
>>>> Hi all,
>>>> could you please review this small patch?
>>>> from JBS:
>>>>> this subtask is to use j.t.l.Utils.getRandomInstance() as a random number generator, where applicable, in : vmTestbase_nsk_sysdict test group and marking the tests which make use of "randomness" with a proper k/w.
>>>> testing: : vmTestbase_nsk_sysdict test group
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8243433
>>>> webrev: http://cr.openjdk.java.net/~iignatyev/8243433/webrev.00
>>>> (all code changes have already happened in 8242314 'use reproducible random in vmTestbase shared code', so just k/w and copyright years this time)
>>>>  Thanks,
>>>> -- Igor



More information about the hotspot-runtime-dev mailing list