RFR: 8244276: Zero and minimal VM build failure after JDK-8178349 (use of undeclared identifier 'SystemDictionaryShared')

David Holmes david.holmes at oracle.com
Sun May 3 09:33:16 UTC 2020


LGTM :)

Thanks,
David

On 3/05/2020 12:21 pm, jiefu(傅杰) wrote:
> Hi Yumin,
> 
> Is it OK to be pushed?
> Or shall we wait for one more review?
> Thanks.
> 
> Best regards,
> Jie
> 
> On 2020/5/2, 11:35 AM, "jiefu(傅杰)" <jiefu at tencent.com> wrote:
> 
>      Thanks Yumin for your review.
>      
>      On 2020/5/2, 11:18 AM, "hotspot-runtime-dev on behalf of Yumin Qi" <hotspot-runtime-dev-bounces at openjdk.java.net on behalf of yumin.qi at oracle.com> wrote:
>      
>          Looks good to me.  I haven't noticed it would fail Zero/Minimal build.
>          
>          Thanks
>          Yumin
>          
>          On 5/1/20 7:44 PM, jiefu(傅杰) wrote:
>          > Hi all,
>          >
>          > May I get reviews for this fix?
>          >
>          > JBS: https://bugs.openjdk.java.net/browse/JDK-8244276
>          > Webrev: http://cr.openjdk.java.net/~jiefu/8244276/webrev.00/
>          >
>          > Thanks a lot.
>          > Best regards,
>          > Jie
>          
>          
>          
>      
>      
> 


More information about the hotspot-runtime-dev mailing list