RFR(T) : 8244485 : runtime/cds/appcds/TestZGCWithCDS.java fails after 8244385

[Daniel D. Daugherty]

On 5/5/20 5:42 PM, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev/8244485/webrev.00/
>> 2 lines changed: 2 ins; 0 del; 0 mod;
> Hi all,
>
> could you please review this (effectively) one-liner?
> from JBS:
>> JDK-8244385 replaced `@requires vm.gc=="null"` with `@requires vm.gc.Z` which is true if JVM supports ZGC and there GC isn't specified or ZGC is selected. so now the test started to run in tier3 w/ ZGC being explicitly selected, which leads to failure in '4. Run with +UseCompressedOops -UseCompressedClassPointers' as +UseZGC implicitly means -UseCompressedClassPointers -UseCompressedOops
>> given other GCs also might affect the value of UseCompressed*, the safe _enough_ choice is to restore `@requires vm.gc== null`. this can lead to the same failure mode though if/when we change default GC.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8244485
> webrev: http://cr.openjdk.java.net/~iignatyev/8244485/webrev.00/

test/hotspot/jtreg/runtime/cds/appcds/TestZGCWithCDS.java
     No comments.

Thumbs up! And I agree that this is a trivial fix.

Dan

> testing: runtime/cds/appcds/TestZGCWithCDS.java w/ UseZGC and w/o any Use*GC flags
>
> Thanks,
> -- Igor
>