RFR: 8244549:[BACKOUT]8237750 patch

Ioi Lam ioi.lam at oracle.com
Wed May 6 21:19:26 UTC 2020


Hi Yumin,

The crash is caused by a bug in 
src/java.base/share/native/libjimage/imageDecompressor.cpp that wrongly 
assumes that zip.dll is already loaded. The fix is pretty simple. So 
instead of backing out your change, it's better to fix 
imageDecompressor.cpp instead.

Please see my evaluation in https://bugs.openjdk.java.net/browse/JDK-8244495

Thanks
- Ioi


On 5/6/20 12:31 PM, Yumin Qi wrote:
> Hi,
>
>     Please review
>   bug: https://bugs.openjdk.java.net/browse/JDK-8244549
>   webrev: http://cr.openjdk.java.net/~minqi/8244549/webrev/
>
>     the patch of bug 
> 8237750(https://bugs.openjdk.java.net/browse/JDK-8237750). 
> <https://bugs.openjdk.java.net/browse/JDK-8237750>
>   failed two tests on Windows (crash):
>    tools/jlink/JLinkTest.java
>    tools/jlink/basic/BasicTest.java
>
>    The original patch: 
> https://hg.openjdk.java.net/jdk/jdk/rev/73a67f19ee67
>
>    Thanks
>    Yumin
> <https://bugs.openjdk.java.net/browse/JDK-8237750>



More information about the hotspot-runtime-dev mailing list