RFR: 8244607: 8244550 broke non-PCH debug builds

Daniel D. Daugherty daniel.daugherty at oracle.com
Thu May 7 13:46:36 UTC 2020


On 5/7/20 9:33 AM, Claes Redestad wrote:
> Hi,
>
> I thought I had purged PCH, but not for fastdebug. Combine that with
> looking at the wrong test job before push and it seems I broke some
> builds - again.
>
> Fix: outline the RM and exception throwing from the now-inlined
> allocate_instance, since ResourceMark constructor is defined in
> .cpp and not .hpp on ASSERT-enabled builds:
>
> http://cr.openjdk.java.net/~redestad/8244607/open.00/
>
> Testing: yes.
>
> /Claes

Aleksey filed JDK-8244606 and has a proposed fix (1 liner) in the comments.

Please figure out which one is going to be closed as a dup...

Dan


More information about the hotspot-runtime-dev mailing list