RFR (XS) 8244606: Non-PCH build is broken after JDK-8244550
Daniel D. Daugherty
daniel.daugherty at oracle.com
Thu May 7 14:03:04 UTC 2020
Thumbs up. Also, this fix is trivial and does not have to wait for 24 hours
to be pushed.
Dan
On 5/7/20 9:55 AM, Claes Redestad wrote:
> Looks good (and better than my fix for the 8244607 dup).
>
> /Claes
>
> On 2020-05-07 15:51, Aleksey Shipilev wrote:
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8244606
>>
>> New code added ResourceMark usage in instanceKlass.inline.hpp, which
>> breaks the build without PCH.
>> The fix is to add an include:
>>
>> diff -r 55c54c172331 src/hotspot/share/oops/instanceKlass.inline.hpp
>> --- a/src/hotspot/share/oops/instanceKlass.inline.hpp Thu May 07
>> 13:59:18 2020 +0100
>> +++ b/src/hotspot/share/oops/instanceKlass.inline.hpp Thu May 07
>> 15:23:27 2020 +0200
>> @@ -27,4 +27,5 @@
>>
>> #include "memory/iterator.hpp"
>> +#include "memory/resourceArea.hpp"
>> #include "oops/instanceKlass.hpp"
>> #include "oops/klass.hpp"
>>
>> Testing: Linux x86_64 {fastdebug,release,slowdebug} builds
>> with/without PCH; jdk-submit (running)
>>
More information about the hotspot-runtime-dev
mailing list