RFR(S): 8242524: Use different default CDS archives depending on UseCompressOops

[Calvin Cheung]

+1

thanks,
Calvin
On 5/14/20 12:26 PM, Ioi Lam wrote:
> Hi Yumin,
>
> Looks good to me. Just one small nit:
>
> +   LogTarget(Info, cds) lt;
> +   if (lt.is_enabled()) {
> +       lt.print("trying to map %s", _full_path);
> +   }
>
> This can be simplified as
>
> log_info(cds)("trying to map %s", _full_path);
>
> NO need for updated webrev.
>
> Thanks
> - Ioi
>
> On 5/14/20 10:40 AM, Yumin Qi wrote:
>> Hi,
>>
>>   Please review:
>>   bug: 8242524: https://bugs.openjdk.java.net/browse/JDK-8242524
>>   webrev: http://cr.openjdk.java.net/~minqi/2020/8242524/webrev-00/
>>
>> Summary:  After 8232069, CDS can create shared archive with 
>> -XX:-UseCompressedOops which also turned off by ZGC. The build with 
>> cds enabled will create basic shared archive classes.jsa which is 
>> default with UseCompressedOops turned on. With this change, the 
>> second shared archive classes_nocoops.jsa will be created with 
>> UseCompressedOops turned off. So now with cds enabled build, there 
>> are two shared archive files will be generated: classes.jsa and 
>> classes_nocoops.jsa. The basic shared archive will be chosen at 
>> runtime based on flag setting that classes.jsa selected with 
>> UseCompressedOops on, and classes_nocoops.jsa will be selected with 
>> UseCompressedOops turned off.
>>
>>   Tests: hs-tier1-4, tier1-2.
>>
>> Thanks
>> Yumin
>