RFR(XXS) 8245335 [TESTBUG] DeterministicDump.java fails with release JVM

[David Holmes]

Hi Ioi,

On 20/05/2020 3:43 am, Ioi Lam wrote:
> https://bugs.openjdk.java.net/browse/JDK-8245335
> http://cr.openjdk.java.net/~iklam/jdk15/8245335-DeterministicDump.java-fails-release-vm.v01/ 
> 
> 
> This test is too aggressive. DeterministicDump.java was created
> in JDK-8241071 (Generation of classes.jsa with -Xshare:dump is not
> deterministic). The goal of JDK-8241071 is for "make images" to produce
> the same bits.
> 
> Since the Makefiles will not specify "-XX:MetaspaceSize=1M", testing 
> with it
> is outside of the scope of JDK-8241071. So this part of the test should
> be removed.

Sounds reasonable - fix looks good.

Minor nits to existing comments:

           // (2) This will cause archive to be relocated during dump 
time. We should

cause ^the^ archive

           //     be mapped at the default location)

period after location.

Thanks,
David

> Thanks
> - Ioi